-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[issue_tracker] Fixes some of the functionality of the module #4690
Conversation
Please don't review just yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove package-lock.json and any console.logs
Hey @zaliqarosli, there isn't any console.logs and I thought we now commit the package-lock.json file. I'm looking at the differences between mine vs the old and it seems that https is now used in mine which is actually better. |
@@ -273,6 +274,13 @@ class IssueForm extends Component { | |||
$.ajax(this.props.DataURL, { | |||
dataType: 'json', | |||
success: function(data) { | |||
console.log(data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaliqarosli hah missed it thanks :)
@maltheism yeahh unsure about the package-lock. i forgot what we decided after that update PR. @johnsaigle do you remember? |
My preference would be to submit updates to I don't really deal much with the JS side though so I think you should just go with whatever works best for you all. |
Hey @zaliqarosli & @johnsaigle my opinion is we just commit the package-lock.json and literally ignore it in PRs. Reason is every time I run |
module seems to be working fine now, need to do a proper testing. whatever the solution is for package-lock.json, i don't think it should be included in this PR so i'm still requesting for it to be removed from this PR. if you want to use |
Hey @zaliqarosli I'm leaving the package-lock.json in this PR. |
Please split this into multiple PRs.. it can't really be reviewed right now, because it doesn't describe what it's fixing, and it's going to conflict with other PRs that are fixing individual problems with the issue tracker. |
you can remove the package-lock.json file from this PR now because #4791 takes care of that |
As far as I can tell, everything that this PR was trying to do has been fixed in other more targeted PRs now. |
Brief summary of changes
Fixes a lot of issue_tracker bugs and the module isn't functional in current state. I'm just publishing this PR right now because it solves a lot of the bugs for geting the module close to working.
Some of the issues: Checkbox not working, Site not being populated in the table, clicking an issue not populating site and I can't remember everything because it was frustrating to debug & fix.
This resolves issue...
Redmine? #
Github? [Issue Tracker] Unable to update "Watching?" field after creating issue #4582
To test this change...